Skip to content

Update doc-build.yml#3045

Closed
svekars wants to merge 6 commits intomainfrom
svekars-patch-1
Closed

Update doc-build.yml#3045
svekars wants to merge 6 commits intomainfrom
svekars-patch-1

Conversation

@svekars
Copy link
Copy Markdown
Contributor

@svekars svekars commented Apr 15, 2024

No description provided.

@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented Apr 15, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/3045

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 06a77ce with merge base ab62707 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Apr 15, 2024
@svekars svekars requested a review from clee2000 April 15, 2024 22:22
@svekars svekars marked this pull request as ready for review April 16, 2024 18:09
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Apr 16, 2024

@svekars has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

dbort
dbort reviewed Apr 16, 2024
View reviewed changes
Comment thread .github/workflows/doc-build.yml
exit 1
case "${REF_NAME}" in
*-rc*)
echo "Aborting upload since this is an RC tag: ${REF_NAME}"
Copy link
Copy Markdown
Contributor

@dbort dbort Apr 16, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment explaining why it makes sense to abort when encountering an RC tag. Is it because we only want to generate docs for the actual release tag?

Copy link
Copy Markdown
Contributor Author

@svekars svekars Apr 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, I believe this is what we do across other repositories - no documentation will be generated for v1.0.0-rc1 or similar.

dbort
dbort reviewed Apr 16, 2024
View reviewed changes
Comment thread .github/workflows/doc-build.yml
@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Apr 16, 2024

@svekars has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Copy Markdown
Contributor

facebook-github-bot commented Apr 16, 2024

@svekars merged this pull request in c73bfc0.

@svekars
Copy link
Copy Markdown
Contributor Author

svekars commented Apr 17, 2024

@pytorchbot cherry-pick --onto release/0.2 -c docs

pytorchbot pushed a commit that referenced this pull request Apr 17, 2024
@svekars @pytorchbot
Update doc-build.yml (#3045)
1f33fac 
Summary: Pull Request resolved: #3045

Reviewed By: clee2000

Differential Revision: D56201946

Pulled By: svekars

fbshipit-source-id: 4212c24b02a1229ff06137b0d437b4e8c5dd454e
(cherry picked from commit c73bfc0)
@pytorchbot
Copy link
Copy Markdown
Collaborator

pytorchbot commented Apr 17, 2024

Cherry picking #3045

The cherry pick PR is at #3098

Details for Dev Infra team Raised by workflow job

@svekars svekars mentioned this pull request Apr 17, 2024
Closed
guangy10 pushed a commit that referenced this pull request Apr 18, 2024
@pytorchbot @svekars
Update doc-build.yml (#3045) (#3098)
59fa8e3 
Summary: Pull Request resolved: #3045

Reviewed By: clee2000

Differential Revision: D56201946

Pulled By: svekars

fbshipit-source-id: 4212c24b02a1229ff06137b0d437b4e8c5dd454e
(cherry picked from commit c73bfc0)

Co-authored-by: Svetlana Karslioglu <svekars@meta.com>
This was referenced Apr 25, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbort dbort dbort left review comments

+1 more reviewer

@clee2000 clee2000 clee2000 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@svekars @facebook-github-bot @pytorchbot @dbort @clee2000